[PATCH] D30941: Better testing of schedule model instruction latencies/throughputs

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 12 08:42:15 PDT 2017


hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D30941#724863, @avt77 wrote:

> I implemeted all requirements from hfinkel.
>  Please, review again.


LGTM, thanks!



================
Comment at: lib/Target/X86/X86Subtarget.h:627
 
+  // TODO: in fact it's true but we keep false to avoid massive test changes
+  bool supportPrintSchedInfo() const override { return false; }
----------------
I'd just say:

 // TODO: Update the regression tests and return true.



https://reviews.llvm.org/D30941





More information about the llvm-commits mailing list