[PATCH] D31920: llvm-lto2: Add a dump-symtab subcommand.

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: llvm/tools/llvm-lto2/llvm-lto2.cpp:297
+    outs() << "source filename: " << Input->getSourceFileName() << '\n';
+    outs() << "linker opts: " << Input->getCOFFLinkerOpts() << '\n';
+
----------------
What if not COFF? Should this line be suppressed?


================
Comment at: llvm/tools/llvm-lto2/llvm-lto2.cpp:318
+      PrintBool('I', Sym.isIndirect());
+      PrintBool('M', Sym.canBeOmittedFromSymbolTable());
+      PrintBool('T', Sym.isTLS());
----------------
Why 'M'? Maybe 'O' for Omitted?


https://reviews.llvm.org/D31920