[llvm] r300016 - Revert "[WebAssembly] Update use of Attributes after r299875"

[Derek Schuff via llvm-commits]

Author: dschuff
Date: Tue Apr 11 20:17:31 2017
New Revision: 300016

URL: http://llvm.org/viewvc/llvm-project?rev=300016&view=rev
Log:
Revert "[WebAssembly] Update use of Attributes after r299875"

This reverts commit 2a0eb61dcccb15058d5b2a572bb3da0cf47fd550, r300015

I raced with rnk on the commit.

Modified:
    llvm/trunk/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp

Modified: llvm/trunk/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp?rev=300016&r1=300015&r2=300016&view=diff
==============================================================================
--- llvm/trunk/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp (original)
+++ llvm/trunk/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp Tue Apr 11 20:17:31 2017
@@ -435,23 +435,26 @@ Value *WebAssemblyLowerEmscriptenEHSjLj:
 
   // Because we added the pointer to the callee as first argument, all
   // argument attribute indices have to be incremented by one.
-  SmallVector<AttributeSetNode *, 8> AttributesVec;
-  const AttributeList &InvokeAL = CI->getAttributes();
-
-  // Add any return attributes.
-  AttributesVec.push_back(InvokeAL.getRetAttributes());
-  // No attributes for the callee pointer.
-  AttributesVec.push_back(nullptr);
-  // Copy the argument attributes from the original
-  for (unsigned i = 1, e = CI->getNumArgOperands(); i <= e; ++i) {
-    AttributesVec.push_back(InvokeAL.getParamAttributes(i));
+  SmallVector<AttributeList, 8> AttributesVec;
+  const AttributeList &InvokePAL = CI->getAttributes();
+  CallSite::arg_iterator AI = CI->arg_begin();
+  unsigned i = 1; // Argument attribute index starts from 1
+  for (unsigned e = CI->getNumArgOperands(); i <= e; ++AI, ++i) {
+    if (InvokePAL.hasAttributes(i)) {
+      AttrBuilder B(InvokePAL, i);
+      AttributesVec.push_back(AttributeList::get(C, i + 1, B));
+    }
   }
-
+  // Add any return attributes.
+  if (InvokePAL.hasAttributes(AttributeList::ReturnIndex))
+    AttributesVec.push_back(
+        AttributeList::get(C, InvokePAL.getRetAttributes()));
   // Add any function attributes.
-  AttributesVec.push_back(InvokeAL.getFnAttributes());
+  if (InvokePAL.hasAttributes(AttributeList::FunctionIndex))
+    AttributesVec.push_back(AttributeList::get(C, InvokePAL.getFnAttributes()));
   // Reconstruct the AttributesList based on the vector we constructed.
-  AttributeList NewCallAL = AttributeList::get(C, AttributesVec);
-  NewCall->setAttributes(NewCallAL);
+  AttributeList NewCallPAL = AttributeList::get(C, AttributesVec);
+  NewCall->setAttributes(NewCallPAL);
 
   CI->replaceAllUsesWith(NewCall);