[PATCH] D31837: [cfi] Run the entire CFI test suite with LLD, if available

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: test/cfi/CMakeLists.txt:4-9
 set(CFI_LIT_TEST_MODE Standalone)
 configure_lit_site_cfg(
   ${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.in
   ${CMAKE_CURRENT_BINARY_DIR}/Standalone/lit.site.cfg
-  )
+)
+list(APPEND CFI_TESTSUITES ${CMAKE_CURRENT_BINARY_DIR}/Standalone)
----------------
This part could be factored into a function at this point.


================
Comment at: test/cfi/CMakeLists.txt:18
+
+if(NOT APPLE AND COMPILER_RT_HAS_LLD)
+  set(CFI_LIT_TEST_USE_LLD 1)
----------------
I think this will cause us to run the tests twice with lld on Windows.


Repository:
  rL LLVM

https://reviews.llvm.org/D31837