[PATCH] D30785: [DWARF] Versioning for DWARF constants; verify FORMs

[Paul Robinson via Phabricator via llvm-commits]

probinson updated this revision to Diff 94905.
probinson added a comment.

Move the version check to DIE::addValue().  This required making the base-class method virtual, because the base class doesn't have a way to find the DWARF version; only a DIE can do that.
Other review comments addressed as well.


https://reviews.llvm.org/D30785

Files:
  include/llvm/CodeGen/DIE.h
  include/llvm/ObjectYAML/DWARFYAML.h
  include/llvm/Support/Dwarf.def
  include/llvm/Support/Dwarf.h
  lib/CodeGen/AsmPrinter/DIE.cpp
  lib/Support/Dwarf.cpp
  test/DebugInfo/AMDGPU/pointer-address-space-dwarf-v1.ll
  test/DebugInfo/AMDGPU/variable-locations-dwarf-v1.ll
  tools/dsymutil/DwarfLinker.cpp
  unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30785.94905.patch
Type: text/x-patch
Size: 76861 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170411/411a6e1c/attachment.bin>