[PATCH] D31350: AMDGPU : Fix common dominator of two incoming blocks terminates with uniform branch issue.

[Wei Ding via Phabricator via llvm-commits]

wdng added inline comments.


================
Comment at: lib/Target/AMDGPU/SIFixSGPRCopies.cpp:344
+
+    Visited.insert(mbb);
+    if (hasTerminatorThatModifiesExec(*mbb, *TRI))
----------------
rampitec wrote:
> If you use Visited.insert(mbb).second it is one search in the set instead of two.
Looks like this is not correct. We need to check whether this node has visited before,  then add into Visited if not found instead of inserting first and then search, correct?


Repository:
  rL LLVM

https://reviews.llvm.org/D31350