[PATCH] D31883: Don't assume PTHREAD_CREATE_JOINABLE is 0 on all systems

Aleksey Shlyapnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 11 10:00:18 PDT 2017


alekseyshl added inline comments.


================
Comment at: lib/lsan/lsan_interceptors.cc:61
+#endif
+
 INTERCEPTOR(void*, malloc, uptr size) {
----------------
Why do we have to define them? why not use the proper definition in phtread.h?


================
Comment at: lib/lsan/lsan_interceptors.cc:283
   AdjustStackSize(attr);
   int detached = 0;
   pthread_attr_getdetachstate(attr, &detached);
----------------
int detached = PTHREAD_CREATE_JOINABLE; to be consistent with the rest of your change.


https://reviews.llvm.org/D31883





More information about the llvm-commits mailing list