[PATCH] D31901: LTO: Pass SF_Executable flag through to InputFile::Symbol

Tobias Edler von Koch via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 11 08:58:33 PDT 2017


tobiasvk marked an inline comment as done.
tobiasvk added a comment.

In https://reviews.llvm.org/D31901#723155, @pcc wrote:

> Agreed with @davide that this needs a test case. I am working on a change to llvm-lto2 that adds a feature for dumping the LTO symbol table, which should allow you to test this. @tobiasvk would you be fine with waiting until that change lands?


Yes, absolutely agree we need a test case. It's just currently not possible to test it inside llvm without the linker, so I couldn't add one. It would be great if you could add a symbol table dump feature to llvm-lto2. Please add me to the review when you get to it, so we can merge this once your patch has landed.

Thanks!


https://reviews.llvm.org/D31901





More information about the llvm-commits mailing list