[PATCH] D31801: Performance enhancements for Cavium ThunderX2 T99

[Stefan Teleman via Phabricator via llvm-commits]

steleman added a comment.

I will re-submit with changes shortly - I also have a few more additions to the *.td
file as well.



================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:7624
+  case AArch64Subtarget::ThunderX2T99:
+  case AArch64Subtarget::ThunderXT88:
+    if (VT.isFloatingPoint() && VT.isVector())
----------------
rengolin wrote:
> This smells like a target feature. :)
I can definitely re-write it as a TargetFeature.



================
Comment at: lib/Target/AArch64/AArch64SchedThunderX2T99.td:370
+//---
+def : InstRW<[THX2T99Write_1Cyc_I2], (instregex "^B")>;
+def : InstRW<[THX2T99Write_1Cyc_I2], (instregex "^BL")>;
----------------
javed.absar wrote:
> nitpick. These could be compressed into fewer lines separated as (instregex a, b, ...).  Also, doesn't "^B" cover "^BL" as well?
Yes I will compress them and re-submit.


Repository:
  rL LLVM

https://reviews.llvm.org/D31801