[PATCH] D31888: [LLD][ELF] Always use Script::assignAddresses()

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 11 02:12:13 PDT 2017


peter.smith updated this revision to Diff 94797.
peter.smith added a comment.

Updated diff to address review comments.
Apologies for leaving PHDRS in, I had originally attempted to merge fixSectionAlignments() into FabricateSectionAlignments(), but decided against it.

I've left in:

  auto I = Config->SectionStartMap.find(Sec->Name);
  if (I != Config->SectionStartMap.end())

Rather than use lookup(). If my understanding is correct, lookup() will return 0 if there is no entry in SectionStart which is a valid address that can be set with -section-start.


https://reviews.llvm.org/D31888

Files:
  ELF/LinkerScript.cpp
  ELF/LinkerScript.h
  ELF/Writer.cpp
  test/ELF/tls-offset.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31888.94797.patch
Type: text/x-patch
Size: 5850 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170411/92b7fb1e/attachment.bin>


More information about the llvm-commits mailing list