[PATCH] D31930: [XRay] [compiler-rt] Simplify FDR logging handler. [NFC]

Martin Pelikán via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 11 00:45:00 PDT 2017


pelikan created this revision.

Not repeating screamy failure paths makes the 300+ line function a bit shorter.
There's no need to overload the variable name "Buffer" if it only works on the
thread local buffer.  Fix some comments while there.

I plan to move the rewinding logic into a separate function too, but in this
diff it would be too much of a mess to comprehend.  This is trivially NFC.


https://reviews.llvm.org/D31930

Files:
  lib/xray/xray_fdr_logging_impl.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31930.94789.patch
Type: text/x-patch
Size: 5331 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170411/9c7e394b/attachment.bin>


More information about the llvm-commits mailing list