[PATCH] D31524: Add a linker script to version LLVM symbols

[Sylvestre Ledru via Phabricator via llvm-commits]

sylvestre.ledru added inline comments.


================
Comment at: cmake/modules/AddLLVM.cmake:85
     add_custom_command(OUTPUT ${native_export_file}
-      COMMAND echo "{" > ${native_export_file}
+      COMMAND echo "LLVM_${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR} {" > ${native_export_file}
       COMMAND grep -q "[[:alnum:]]" ${export_file} && echo "  global:" >> ${native_export_file} || :
----------------
rnk wrote:
> Is this correct for DSOs that aren't libLLVM.so.N.M? This function is called from LLDB and elsewhere.
It doesn't have too. libLLVM.so.N.M is for the SONAME.
However, I can rename it, no worries


Repository:
  rL LLVM

https://reviews.llvm.org/D31524