[PATCH] D31875: [AVR] Migrate to new MCAsmBackend applyFixup

[Leslie Zhai via Phabricator via llvm-commits]

xiangzhai added a comment.

Hi Jonathan,

Thanks for your review!

> Why didn't the lack of this break the build?

In file included from /data/project/LLVM/llvm/lib/Target/AVR/MCTargetDesc/AVRAsmBackend.cpp:14:
/data/project/LLVM/llvm/lib/Target/AVR/MCTargetDesc/AVRAsmBackend.h:44:55: error: non-virtual member function marked 'override' hides virtual member function

  uint64_t Value, bool IsPCRel) const override;
                                      ^

/data/project/LLVM/llvm/include/llvm/MC/MCAsmBackend.h:76:16: note: hidden overloaded virtual function 'llvm::MCAsmBackend::applyFixup' declared here: different number of parameters (6 vs 5)

  virtual void applyFixup(const MCFixup &Fixup, char *Data, unsigned DataSize,
               ^

/data/project/LLVM/llvm/lib/Target/AVR/MCTargetDesc/AVRAsmBackend.cpp:469:14: error: allocating an object of abstract class type 'llvm::AVRAsmBackend'

  return new AVRAsmBackend(TT.getOS());
             ^

/data/project/LLVM/llvm/include/llvm/MC/MCAsmBackend.h:76:16: note: unimplemented pure virtual method 'applyFixup' in 'AVRAsmBackend'

  virtual void applyFixup(const MCFixup &Fixup, char *Data, unsigned DataSize,
               ^

2 errors generated.

And I do not have commit access, please commit it on my behalf, thanks a lot!

Regards,
Leslie Zhai


Repository:
  rL LLVM

https://reviews.llvm.org/D31875