[PATCH] D31751: [LLD][ELF] Tidy up handleARMTlsRelocation [NFC]

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 10 18:38:28 PDT 2017


ruiu added inline comments.


================
Comment at: ELF/Target.cpp:1842
   case R_ARM_TLS_TPOFF32:
+  case R_ARM_TLS_DTPOFF32:
     write32le(Loc, Val);
----------------
Why do you need this?


================
Comment at: ELF/Target.cpp:1845-1847
   case R_ARM_TLS_DTPMOD32:
     write32le(Loc, 1);
     break;
----------------
This is not a comment to this particular patch, but we need to remove this piece of code and instead create a way to just set "1" to .got without using this type of relocation in an odd way.


https://reviews.llvm.org/D31751





More information about the llvm-commits mailing list