[PATCH] D31912: [asan] Give global metadata private linkage.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:1694
     GlobalVariable *Liveness = new GlobalVariable(
-        M, LivenessTy, false, GlobalVariable::InternalLinkage, LivenessBinder,
+        M, LivenessTy, false, GlobalVariable::PrivateLinkage, LivenessBinder,
         Twine("__asan_binder_") + G->getName());
----------------
I suspect that private linkage isn't correct for darwin because the symbols need to be present in the object files for dead stripping to work, but I'll ask @kubamracek to comment on that.


Repository:
  rL LLVM

https://reviews.llvm.org/D31912