[PATCH] D29631: SystemZTargetTransformInfo cost functions and some common code changes

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 10 14:21:22 PDT 2017


uweigand added a comment.

See one inline comment.  Otherwise the SystemZ changes still LGTM, and we now also have positive benchmark results for this change ...



================
Comment at: lib/Target/SystemZ/SystemZTargetTransformInfo.cpp:758
+    // Give a slight penalty for moving out of vector pipeline to FXU unit.
+    if (Index == 0 && Val->getScalarType()->isIntegerTy())
+      Cost += 1;
----------------
Why just index == 0 ? Shouldn't the penalty apply to any element?


https://reviews.llvm.org/D29631





More information about the llvm-commits mailing list