[PATCH] D31704: [BPI] NFC: reorder ifs to bail out earlier

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

LGTM, seems like a clear improvement in this code. See one nit about the asserts below, but feel free to submit with that addressed.



================
Comment at: lib/Analysis/BranchProbabilityInfo.cpp:208
   const TerminatorInst *TI = BB->getTerminator();
-  if (TI->getNumSuccessors() == 0)
+  assert(TI->getNumSuccessors() > 1);
+
----------------
Nit: add a message here and elsewhere. like "expected more than one successor!" to help confirm that the assert isn't a typo or something.


https://reviews.llvm.org/D31704