[PATCH] D31828: Bitcode: Move version and global value module code parsers to separate functions. NFCI.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:388
+  /// not need this flag.
+  bool UseRelativeIDs = false;
+
----------------
tejohnson wrote:
> Why move this into BitcodeReaderBase, rather than BitcodeReader?
In D31838 the code that reads names is shared between the module reader and the summary reader. That code needs to know the module version, so I needed to move the module version parsing code into the base class, including the fields that it sets.


https://reviews.llvm.org/D31828