[PATCH] D31811: [compiler-rt] Add virtual destructor to base class to avoid warning

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

No, this has already landed and been reverted once:

  commit d6944a2ff309db0b60216c65708f65c18d5cb8c7
  Author: Ivan Krasin <krasin at chromium.org>
  Date:   Thu Apr 6 18:22:25 2017 +0000
  
      Revert r299672: Add a virtual destructor to a class with virtual methods.
  
      Reason: breaks sanitizers builds.
  
      Original Differential Revision: https://reviews.llvm.org/D317
  
  Notes:
      git-svn-rev: 299679
  
  commit 7a21a8532432c1f2f183ac2d1089bdb2ff6950eb
  Author: Ivan Krasin <krasin at chromium.org>
  Date:   Thu Apr 6 17:58:45 2017 +0000
  
      Add a virtual destructor to a class with virtual methods.
  
      Summary:
      Recently, Clang enabled the check for virtual destructors
      in the presence of virtual methods. That broke the bootstrap
      build. Fixing it.
  
      Reviewers: pcc
  
      Reviewed By: pcc
  
      Subscribers: llvm-commits, kubamracek
  
      Differential Revision: https://reviews.llvm.org/D31776
  
  Notes:
      git-svn-rev: 299672


Repository:
  rL LLVM

https://reviews.llvm.org/D31811