[PATCH] D30951: [AArch64] Simplify MacroFusion

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 10 11:32:30 PDT 2017


MatzeB added a comment.

- Please upload patches with context!
- Variables names here are becoming hard to understand with each revision, please add comments or rename to something that makes sense:
  - LMI, RMI: What does L and R stand for? Left/Right, what would that mean? (Before the variable only existed in a DEBUG() section so I didn't care, not it is used in more places with variants like LSU/RSU).
  - ASU, BSU, XSU. I guess this made sense when it only was A/B in a first/second sense. Now we have X in the mix and it gets confusing.


Repository:
  rL LLVM

https://reviews.llvm.org/D30951





More information about the llvm-commits mailing list