[PATCH] D31767: [LLVM][X86][SSE] Update MOVNTDQA non-temporal loads to generic implementation

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/IR/AutoUpgrade.cpp:1878
+      Module *M = F->getParent();
+      SmallVector<Metadata *, 1> Elts;
+      Elts.push_back(
----------------
craig.topper wrote:
> I know we already do this in several places in this file, but why do we need a SmallVector of 1? Won't a single Metadata * variable auto convert to ArrayRef for the MDNode::get call?
OK - I'll fix it in this one and fix the others as followups.


================
Comment at: lib/IR/AutoUpgrade.cpp:1884
+      Value *Ptr = CI->getArgOperand(0);
+      VectorType *VTy = cast<VectorType>(CI->getType());
+
----------------
craig.topper wrote:
> Do we need a VectorType for the two calls that use this or could it just be generic Type*?
IIRC we need the VectorType for the getBitWidth() call.


Repository:
  rL LLVM

https://reviews.llvm.org/D31767