[PATCH] D31832: Improves pretty printing of variable types in llvm-pdbdump

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth marked 4 inline comments as done.
amccarth added a comment.

Thanks for the review, especially for the heads up on the merge points.



================
Comment at: llvm/tools/llvm-pdbdump/PrettyVariableDumper.cpp:170-172
+  auto PointeeType = Symbol.getPointeeType();
+  if (!PointeeType)
+    return;
----------------
zturner wrote:
> I wonder if it's worth asserting here.  You can still return if it's null, but it seems like a bad PDB file at the same time.
Agreed.  I was following a pattern I saw in other parts of the code, but the assert makes sense.  I've also added the for ElementType in the array cases.


https://reviews.llvm.org/D31832