[PATCH] D30941: Better testing of schedule model instruction latencies/throughputs

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/MC/MCAsmStreamer.cpp:106
   /// AddEncodingComment - Add a comment showing the encoding of an instruction.
-  void AddEncodingComment(const MCInst &Inst, const MCSubtargetInfo &);
+  void AddEncodingComment(const MCInst &Inst, const MCSubtargetInfo &,
+                          bool PrintSchedInfo);
----------------
RKSimon wrote:
> Explain how PrintSchedInfo will be used in comment
Don't use @param - you have to provide all params otherwise Wdocumentation fires.


================
Comment at: lib/Target/X86/X86Subtarget.cpp:380
+                                     Optional<double> RThroughput) {
+  static char *SchedPrefix = const_cast <char *> (" sched: [");
+  std::string Comment;
----------------
const char *SchedPrefix = " sched: [";


https://reviews.llvm.org/D30941