[PATCH] D30680: new method TargetTransformInfo::supportsVectorElementLoadStore() for LoopVectorizer

Adam Nemet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 10 11:05:42 PDT 2017


anemet added inline comments.


================
Comment at: include/llvm/Analysis/TargetTransformInfo.h:437-439
+  /// If target has vector element load/store instructions, it can return
+  /// true here so that insertion/extraction costs are not added to the
+  /// scalarization cost of a load/store.
----------------
Again, this should not state the presence of these instructions but whether they are as efficient as their scalar counterparts.  Please rephrase.

It's probably even better to express this in the name of the hook, e.g. supportsEfficientVectorElementLoadStore.


https://reviews.llvm.org/D30680





More information about the llvm-commits mailing list