[PATCH] D31749: [LLD][ELF] Fix ARM TLS global dynamic TlsOffsetRel for non-preemtible symbols

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

I've used the regular relocation code for this change.



================
Comment at: ELF/Relocations.cpp:192
+        Got->Relocations.push_back(
+            {R_ABS, Target->TlsOffsetRel, Off + Config->Wordsize, 0, &Body});
     }
----------------
ruiu wrote:
> Can this be more regular relocation rathe rthan TlsOffsetRel? What we want to do is to set a symbol value to the got offset, so it doesn't have to be a TLS relocation, no?
It can be, but doing so makes the later refactoring to have one AddTlsReloc() function more difficult as we can give that function the same relocation code in both cases. Given that refactoring D31751 isn't approved yet I'll use a more regular code, we can always change it back in D31751.  


Repository:
  rL LLVM

https://reviews.llvm.org/D31749