[PATCH] D31786: AMDGPU/GFX9: Fix shared and private aperture queries
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 6 13:37:18 PDT 2017
arsenm added inline comments.
================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:2356
SelectionDAG &DAG) const {
-
- if (Subtarget->hasApertureRegs()) { // Read from Aperture Registers directly.
- unsigned RegNo = (AS == AMDGPUASI.LOCAL_ADDRESS) ? AMDGPU::SRC_SHARED_BASE :
- AMDGPU::SRC_PRIVATE_BASE;
- return CreateLiveInRegister(DAG, &AMDGPU::SReg_32RegClass, RegNo, MVT::i32);
+ // FIXME: Use inline constants (src_{shared, private}_base) instead.
+ if (Subtarget->hasApertureRegs()) {
----------------
What's wrong with using these now?
================
Comment at: lib/Target/AMDGPU/SIRegisterInfo.td:47-51
-def SRC_SHARED_BASE : SIReg<"src_shared_base", 235>;
-def SRC_SHARED_LIMIT : SIReg<"src_shared_limit", 236>;
-def SRC_PRIVATE_BASE : SIReg<"src_private_base", 237>;
-def SRC_PRIVATE_LIMIT : SIReg<"src_private_limit", 238>;
-
----------------
Why delete this?
https://reviews.llvm.org/D31786
More information about the llvm-commits
mailing list