[PATCH] D31722: [llvm-extract] Add option for recursive extraction

[Keno Fischer via Phabricator via llvm-commits]

loladiro added inline comments.


================
Comment at: tools/llvm-extract/llvm-extract.cpp:21-23
 #include "llvm/IR/Module.h"
 #include "llvm/IRReader/IRReader.h"
-#include "llvm/IR/LegacyPassManager.h"
----------------
davide wrote:
> Also this reordering seems unrelated? I think it's a good cleanup but can be committed separately (without pre-commit code review).
I run git clang-format as a commit hook and it reorders the include list. Happy to commit separately, but I though the general policy on that was just to put formatting changes into the commit where you're editing the code.


================
Comment at: tools/llvm-extract/llvm-extract.cpp:244
+      Workqueue.pop_back();
+      ExitOnErr(F->materialize());
+      for (auto &BB : *F) {
----------------
davide wrote:
> Can we have a slightly better diagnostic here? Something like Cannot materialize function `F` + `F->getName()`.
IIRC, ExitOnError will add diagnostics if the Error object provides them.


https://reviews.llvm.org/D31722