[PATCH] D31759: [SDAG] Fix visitAND optimization to deal with vector extract case again.

Nirav Dave via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 6 12:18:30 PDT 2017


This revision was automatically updated to reflect the committed changes.
Closed by commit rL299688: [SDAG] Fix visitAND optimization to deal with vector extract case again. (authored by niravd).

Changed prior to commit:
  https://reviews.llvm.org/D31759?vs=94363&id=94415#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D31759

Files:
  llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  llvm/trunk/test/CodeGen/ARM/pr32545.ll


Index: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
===================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
+++ llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
@@ -3589,7 +3589,7 @@
       SDValue NewLoad(Load, 0);
 
       // Fold the AND away. NewLoad may get replaced immediately.
-      CombineTo(N, NewLoad);
+      CombineTo(N, (N0.getNode() == Load) ? NewLoad : N0);
 
       if (Load->getExtensionType() == ISD::EXTLOAD) {
         NewLoad = DAG.getLoad(Load->getAddressingMode(), ISD::ZEXTLOAD,
Index: llvm/trunk/test/CodeGen/ARM/pr32545.ll
===================================================================
--- llvm/trunk/test/CodeGen/ARM/pr32545.ll
+++ llvm/trunk/test/CodeGen/ARM/pr32545.ll
@@ -0,0 +1,22 @@
+; RUN: llc %s -o - | FileCheck %s
+
+target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S64"
+target triple = "armv7--linux-gnueabi"
+
+; CHECK: vld1.16	{[[DREG:d[0-9]+]][0]}, {{.*}}
+; CHECK: vmovl.u8	[[QREG:q[0-9]+]], [[DREG]]
+; CHECK: vmovl.u16	[[QREG]], [[DREG]]
+
+define void @f(i32 %dstStride, i8* %indvars.iv, <2 x i8>* %zz) {
+entry:
+  br label %for.body
+
+for.body:
+  %tmp = load <2 x i8>, <2 x i8>* %zz, align 1
+  %tmp1 = extractelement <2 x i8> %tmp, i32 0
+  %.lhs.rhs = zext i8 %tmp1 to i32
+  call void @g(i32 %.lhs.rhs)
+  br label %for.body
+}
+
+declare void @g(i32)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31759.94415.patch
Type: text/x-patch
Size: 1405 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170406/e55df8f7/attachment.bin>


More information about the llvm-commits mailing list