[compiler-rt] r299679 - Revert r299672: Add a virtual destructor to a class with virtual methods.

Ivan Krasin via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 6 11:22:25 PDT 2017


Author: krasin
Date: Thu Apr  6 13:22:25 2017
New Revision: 299679

URL: http://llvm.org/viewvc/llvm-project?rev=299679&view=rev
Log:
Revert r299672: Add a virtual destructor to a class with virtual methods.

Reason: breaks sanitizers builds.

Original Differential Revision: https://reviews.llvm.org/D317


Modified:
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_flag_parser.h

Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_flag_parser.h
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_flag_parser.h?rev=299679&r1=299678&r2=299679&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_flag_parser.h (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_flag_parser.h Thu Apr  6 13:22:25 2017
@@ -22,7 +22,6 @@ namespace __sanitizer {
 
 class FlagHandlerBase {
  public:
-  virtual ~FlagHandlerBase() {}
   virtual bool Parse(const char *value) { return false; }
 };
 




More information about the llvm-commits mailing list