[PATCH] D31776: Add a virtual destructor to a class with virtual methods.

Ivan Krasin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 6 11:07:02 PDT 2017


krasin created this revision.
Herald added a subscriber: kubamracek.

Recently, Clang enabled the check for virtual destructors
in the precense of virtual methods. That broke the bootstrap
build. Fixing it.


https://reviews.llvm.org/D31776

Files:
  lib/sanitizer_common/sanitizer_flag_parser.h


Index: lib/sanitizer_common/sanitizer_flag_parser.h
===================================================================
--- lib/sanitizer_common/sanitizer_flag_parser.h
+++ lib/sanitizer_common/sanitizer_flag_parser.h
@@ -22,6 +22,7 @@
 
 class FlagHandlerBase {
  public:
+  virtual ~FlagHandlerBase() {}
   virtual bool Parse(const char *value) { return false; }
 };
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31776.94397.patch
Type: text/x-patch
Size: 371 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170406/6b5449a8/attachment.bin>


More information about the llvm-commits mailing list