[PATCH] D31672: [LLD][ELF] Fix ARM TLS global dynamic TlsOffsetRel for non-preemptible symbols

[Rafael Avila de Espindola via llvm-commits]

I somewhat like it that we use relocations. In particular, we should not make 1 a special case. When using elf_rel we use relocations to write the addend for example. 

Having the decision in one place about all the relocations that we need seems a good thing.

Cheers,
Rafael

On April 5, 2017 7:32:02 PM EDT, Rui Ueyama via Phabricator <reviews at reviews.llvm.org> wrote:
>ruiu added a comment.
>
>Currently, we add a relocation to a GOT section to set a GOT slot for a
>TLS variable to 1. But that is an intricate way of setting it to 1,
>because when we add a relocation, we already have a reference to GOT.
>We should be able to directly set it to 1, instead of doing it
>indirectly using relocate().
>
>What I was trying to do is to separate the GOT class into two classes
>-- one for the regular GOT and the other is for TLS variables. TLS
>variables use GOT slots very differently than regular variables, I
>think that will reduce complexity. (But doing that isn't easy as I
>don't understand some parts of MIPS/AArch64 TLS variables ABIs.)
>
>
>https://reviews.llvm.org/D31672

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170406/6d123457/attachment.html>