[PATCH] D30699: [ELF] - Stop producing broken output for R_386_GOT32X relocation.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 6 00:58:58 PDT 2017
grimar added inline comments.
================
Comment at: ELF/Target.cpp:394
+ // resolves to an offset in GOT table (R_GOT_FROM_END), but when instruction
+ // pointed by relocation has no base register, this relocation can be used
+ // when PIC code is disabled. In that case it resolves to address of entry
----------------
ruiu wrote:
> What is "this" in this sentence?
I rewrote this comment, hope it is more readable now.
================
Comment at: ELF/Target.cpp:406
+ error(toString(S.File) +
+ ": relocation R_386_GOT32/R_386_GOT32X against '" + S.getName() +
+ "' without base register can not be used when PIC enabled");
----------------
ruiu wrote:
> You want to use `toString(Type)` instead of R_386_GOT32/R_386_GOT32X.
Fixed.
https://reviews.llvm.org/D30699
More information about the llvm-commits
mailing list