[PATCH] D31735: ThinLTOBitcodeWriter: delete comdats if their keys are renamed
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 5 18:00:28 PDT 2017
mehdi_amini added a comment.
> COFF requires that every comdat contain a symbol with the same name as the comdat.
Is there a verifier for this? Also if I read correctly your test-case, the symbol `@foo` isn't part of the comdat `$foo`?
It isn't clear to me that this patch isn't working around a bug somewhere else.
https://reviews.llvm.org/D31735
More information about the llvm-commits
mailing list