[PATCH] D31733: [IR] Put the Use list waymarking bits in the bit positions documentation says they are using

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 5 16:56:57 PDT 2017


mehdi_amini added inline comments.


================
Comment at: include/llvm/IR/Use.h:64
 
+  /// Pointer traits for the UserRef PointerIntPair.
+  struct UserRefPointerTraits {
----------------
I'd document the motivation for the traits (i.e. for using the LSB independently of the platform IIUC).


================
Comment at: include/llvm/IR/Use.h:77
+
+  /// Pointer traits for the Prev PointerIntPair.
+  struct PrevPointerTraits {
----------------
same here :)


https://reviews.llvm.org/D31733





More information about the llvm-commits mailing list