[PATCH] D31672: [LLD][ELF] Fix ARM TLS global dynamic TlsOffsetRel for non-preemptible symbols

Rafael Ávila de Espíndola via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 5 15:24:36 PDT 2017


rafael added a comment.

It is now hard to read the fix. Can you split this in a refactoring patch and a fix patch?



================
Comment at: ELF/Relocations.cpp:140
+// handling in to the separate function we can simplify the code and do not
+// pollute other `handleTlsRelocation` by MIPS `ifs` statements.
+// ARM is logically similar to MIPS but differs enough in the details to make
----------------
copy and paste of MIPS.


https://reviews.llvm.org/D31672





More information about the llvm-commits mailing list