[PATCH] D31727: [Bugpoint] Use `unique_ptr` correctly.
Rafael Ávila de Espíndola via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 5 15:09:40 PDT 2017
rafael added inline comments.
================
Comment at: tools/bugpoint/Miscompilation.cpp:229
static Expected<std::unique_ptr<Module>>
-testMergedProgram(const BugDriver &BD, std::unique_ptr<Module> M1,
- std::unique_ptr<Module> M2, bool &Broken) {
- if (Linker::linkModules(*M1, std::move(M2)))
+testMergedProgram(const BugDriver &BD, Module &M1, Module &M2, bool &Broken) {
+ // Resulting merge of M1 and M2.
----------------
Can you pass a const ref for M1 and M2?
Repository:
rL LLVM
https://reviews.llvm.org/D31727
More information about the llvm-commits
mailing list