[PATCH] D31614: Simplify test a bit

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 5 13:37:01 PDT 2017


On 5 April 2017 at 14:44, Reid Kleckner via Phabricator
<reviews at reviews.llvm.org> wrote:
> rnk accepted this revision.
> rnk added a comment.
> This revision is now accepted and ready to land.
>
> lgtm
>
> Sure, this is simpler, and I'm not concerned about FileCheck blowing out a 4MB stack.
>
> Do you want to add `REQUIRES: shell` in this change as well, since this test probably still fails with "ulimit: command not found" when setting `LIT_USE_INTERNAL_SHELL=1`?

Probably, but I am saving "REQUIRES: shell" for last so we can have a
discussion on what we don't want to implement in the internal shell
for now.

Cheers,
Rafael


More information about the llvm-commits mailing list