[PATCH] D31583: StackColoring: smarter check for slot overlap

Ariel Ben-Yehuda via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 5 10:27:06 PDT 2017


arielb1 added a comment.

In https://reviews.llvm.org/D31583#719207, @dberlin wrote:

> To try to echo a bit what than is saying:, i think it would be helpful if you could write some paragraphs of what you think the high level design of this new part is.
>
> IE something like:
>  we create a dataflow problem that tells us x
>  we do this by computing these attributes on a per-block basis, and then finding a maximal fixpoint.
>  We then use x to prune y.
>
> or whatever.
>
> I can think of a lot of different approaches than stack coloring currently takes (IE you could do real liveness analysis, as than mentions, you could build interference graphs and simplify them, etc), but they are more fundamental changes than i see here.


I have a big comment in the source code that is supposed to be that explanation. Is there anything missing?


https://reviews.llvm.org/D31583





More information about the llvm-commits mailing list