[PATCH] D31674: [AsmParser]Emit an error if a macro has two (or more) parameters sharing the same name

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.

Please address the issue that @rengolin pointed out.  There is no reason to have an explicit triple here, as the test is agnostic.  Just drop the `nop` in the macro.



================
Comment at: lib/MC/MCParser/AsmParser.cpp:3880
+      if (CurrParam.Name.equals(Parameter.Name))
+        return TokError("macro '" + Name + "' has at least two parameters"
+                        " named '" + Parameter.Name + "'");
----------------
I think I would prefer `multiple` rather than `at least two`.


Repository:
  rL LLVM

https://reviews.llvm.org/D31674