[PATCH] D31679: Use PMADDWD to expand reduction in a loop

[Wei Mi via Phabricator via llvm-commits]

wmi added inline comments.


================
Comment at: test/CodeGen/X86/madd.ll:24
+
+define i32 @_Z10test_shortPsS_i(i16* nocapture readonly, i16* nocapture readonly, i32) local_unnamed_addr #0 {
+  %4 = icmp sgt i32 %2, 0
----------------
The test can be simpler by removing the preheader and exit. just like what test/CodeGen/X86/sad.ll does. It will be easier if it is needed to extend the test and check different kinds of element types or different vector lengths.


https://reviews.llvm.org/D31679