[PATCH] D31459: [Polly][NewPM] Port ScopDetection to the new PassManager

[Philip Pfaffe via Phabricator via llvm-commits]

philip.pfaffe added a comment.

In https://reviews.llvm.org/D31459#718991, @grosser wrote:

> Out of interest: What is the RegionInfo bug you are talking about?


Region-objects capture the address of the creating RegionInfo instance. RegionInfo is movable, and after a move performed by the AnalysisManager, most accesses to the Region objects segfault. This will be a rather noisy fix, because I'll probably need to strictly decouple the Regions from RegionInfo.

Is the RegionInfoAnalysis actually maintained by the Polly community?



================
Comment at: lib/Analysis/ScopDetection.cpp:1615
+static void updateLoopCountStatistic(ScopDetection::LoopStats Stats,
+                                     bool OnlyProfitable) {
   if (!OnlyProfitable) {
----------------
grosser wrote:
> Is this change related. If it is not, I suggest to commit this as-obvious without further review.
> 
> (Do you have commit access. If not please ask Chris for commit access. Your code is great and I believe you have plans for further contributions).
It's not related. Will commit seperately!


https://reviews.llvm.org/D31459