[PATCH] D31625: [SDAG] Fix CombineTo ordering in visitZERO_EXTEND and visitSIGN_EXTEND

James Molloy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 5 00:57:38 PDT 2017


jmolloy added a comment.

Hi,

> Barring comments, my default plan is to mark the shared subset of instructions across the RUN calls that make sense.

As Renato said previously, a sequence of 3-4 CHECK lines is normally more than sufficient. Any more than that and I start to worry about what the test is actually checking for.

James


https://reviews.llvm.org/D31625





More information about the llvm-commits mailing list