[lld] r299504 - Remove default arguments because they don't improve readability.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 4 20:20:23 PDT 2017


Author: ruiu
Date: Tue Apr  4 22:20:22 2017
New Revision: 299504

URL: http://llvm.org/viewvc/llvm-project?rev=299504&view=rev
Log:
Remove default arguments because they don't improve readability.

Modified:
    lld/trunk/ELF/LinkerScript.cpp
    lld/trunk/ELF/LinkerScript.h

Modified: lld/trunk/ELF/LinkerScript.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/LinkerScript.cpp?rev=299504&r1=299503&r2=299504&view=diff
==============================================================================
--- lld/trunk/ELF/LinkerScript.cpp (original)
+++ lld/trunk/ELF/LinkerScript.cpp Tue Apr  4 22:20:22 2017
@@ -644,7 +644,7 @@ void LinkerScript::assignOffsets(OutputS
     return;
 
   if (Cmd->AddrExpr && (Sec->Flags & SHF_ALLOC))
-    setDot(Cmd->AddrExpr, Cmd->Location);
+    setDot(Cmd->AddrExpr, Cmd->Location, false);
 
   if (Cmd->LMAExpr) {
     uint64_t D = Dot;
@@ -858,7 +858,7 @@ void LinkerScript::placeOrphanSections()
 void LinkerScript::processNonSectionCommands() {
   for (const std::unique_ptr<BaseCommand> &Base : Opt.Commands) {
     if (auto *Cmd = dyn_cast<SymbolAssignment>(Base.get()))
-      assignSymbol(Cmd);
+      assignSymbol(Cmd, false);
     else if (auto *Cmd = dyn_cast<AssertCommand>(Base.get()))
       Cmd->Expression();
   }
@@ -872,7 +872,7 @@ void LinkerScript::assignAddresses(std::
 
   for (const std::unique_ptr<BaseCommand> &Base : Opt.Commands) {
     if (auto *Cmd = dyn_cast<SymbolAssignment>(Base.get())) {
-      assignSymbol(Cmd);
+      assignSymbol(Cmd, false);
       continue;
     }
 

Modified: lld/trunk/ELF/LinkerScript.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/LinkerScript.h?rev=299504&r1=299503&r2=299504&view=diff
==============================================================================
--- lld/trunk/ELF/LinkerScript.h (original)
+++ lld/trunk/ELF/LinkerScript.h Tue Apr  4 22:20:22 2017
@@ -224,8 +224,8 @@ struct ScriptConfiguration {
 
 class LinkerScript {
 protected:
-  void assignSymbol(SymbolAssignment *Cmd, bool InSec = false);
-  void setDot(Expr E, const Twine &Loc, bool InSec = false);
+  void assignSymbol(SymbolAssignment *Cmd, bool InSec);
+  void setDot(Expr E, const Twine &Loc, bool InSec);
 
   std::vector<InputSectionBase *>
   computeInputSections(const InputSectionDescription *);




More information about the llvm-commits mailing list