[PATCH] D31632: ThinLTOBitcodeWriter: handle aliases first in filterModule

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: test/ThinLTO/X86/promote-internals.ll:13-21
+define i32 @bar() {
+  %call = call i32 @foo()
+  ret i32 %call
+}
+
+define internal i32 @foo() unnamed_addr align 2 {
+  store i8** @al, i8*** null, align 8
----------------
inglorion wrote:
> pcc wrote:
> > Do you need these functions? I think you should be able to trigger the bug without them if you give @al external linkage.
> Doing that leads to a different error ("GlobalValue not found in index"). That error is also addressed by this patch (specifically, by the change from I-> to GA->), but can be triggered with or without the change to when we process aliases. For that reason, I've elected to keep the functions in the test - but I can remove them if you really want me to.
If I make just the I-> to GA-> change locally I still get the "GlobalValue not found in index" assertion failure with your test case with the functions removed. I would just remove them because the assertion failure is being caused by the same underlying issue.


https://reviews.llvm.org/D31632