[PATCH] D30818: [lsan] Don't handle DTLS of thread under destruction

Evgeniy Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 4 16:43:02 PDT 2017


eugenis accepted this revision.
eugenis added a comment.

LGTM



================
Comment at: lib/lsan/lsan_common.cc:208
+      Report("Unable to get registers from thread %d.\n", os_id);
+      // If unable to get SP, consider the entire stack to be reachable unless
+      // GetRegistersAndSP failed with ESRCH.
----------------
Any idea why is it OK to continue if the registers can not be read, and when can that happen? There is nothing in git history...


Repository:
  rL LLVM

https://reviews.llvm.org/D30818





More information about the llvm-commits mailing list