[PATCH] D31614: Simplify test a bit

[Rafael Espíndola via llvm-commits]

ulimit is a builtin, yes.

If using an external shell, the only difference is that now FileCheck
is constrained by it too.

If using an internal shell this still fails, but with a different
message. The improvement is that this is simpler and opens the way for
having ulimit implemented (or ignored) by the builtin shell one day.

Ignoring ulimit in cases like this makes some sense. It is only a
safety measure. It is not trying to force a test to crash, it just
just making sure the test passes even in the more constrained
environment.

If we ever want to get fancy, we should replace the use of ulimit with
something like "%ulimit ... cmd" so that it can be set to something
that sets the limit on a remote execution target like we do for the
ps4 (and assume something similar is done for android).

Cheers,
Rafael


On 3 April 2017 at 21:37, Reid Kleckner via Phabricator
<reviews at reviews.llvm.org> wrote:
> rnk added a comment.
>
> I thought ulimit was a bash builtin that affects the limits of the shell process. Even if ulimit exists as a separate command, I don't think shelling out to it will affect the parent process. Maybe this is a good place to run `bash -c`?
>
>
> https://reviews.llvm.org/D31614
>
>
>