[PATCH] D31625: [SDAG] Fix CombineTo ordering in visitZERO_EXTEND and visitSIGN_EXTEND

[Nirav Davé via llvm-commits]

The cases unfortunately can't be stripped down too much but I've done at
least a reasonable amount. I'm happy to avoid FileCheck for these tests and
have removed them.

-Nirav

On Tue, Apr 4, 2017 at 11:01 AM, James Molloy via Phabricator <
reviews at reviews.llvm.org> wrote:

> jmolloy added a comment.
>
> You're still checking the entire codegen output for this function. That's
> not what this test is about; this doesn't add any value, all it does is add
> maintenance burden.
>
> Can the test be reduced at all?
>
> I think, at least for this case, I respectfully disagree with Chandler and
> don't see the utility in adding FileCheck lines.
>
> James
>
>
> https://reviews.llvm.org/D31625
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170404/e8967fba/attachment.html>