[PATCH] D30699: [ELF] - Stop producing broken output for R_386_GOT32X relocation.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/Target.cpp:379
+  //  64-ia-32-architectures-software-developer-instruction-set-reference-manual-325383.pdf)
+  if (Type == R_386_GOT32X) {
+    if ((Loc[-1] & 0xc7) != 0x5)
----------------
rafael wrote:
> Why the if? Just use the existing switch.
Done.


================
Comment at: test/ELF/got32x-i386.s:9
+##  .globl ifunc
+##  .type ifunc, @function
+##  ifunc:
----------------
rafael wrote:
> You don't need an ifunc for this, please simplify.
Ok, though below in comments I had explained why I did that (because for futher patches it is convinent to have ifunc here since it will not be affected by relocation optimization). We can go for start with non-ifunc also, not a problem.


https://reviews.llvm.org/D30699