[PATCH] D31350: AMDGPU : Fix common dominator of two incoming blocks terminates with uniform branch issue.

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/SIFixSGPRCopies.cpp:393
+                                                           N->getIDom();
+          if (!hasTerminatorThatModifiesExec(*parentBB, *TRI) && IPostDom) {
+            DEBUG(dbgs() << "Not fixing PHI for uniform branch: "
----------------
I do not understand this. If we speak about %vreg5 from the code in the description, it is not defined by the post dominator. Its definitions are in BB#1 and BB#3 and both needs to be checked.


Repository:
  rL LLVM

https://reviews.llvm.org/D31350