[PATCH] D31603: [ELF] Fail the link early if a map file path is invalid

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/Filesystem.cpp:73
 // if the given file is writable.
-bool elf::isFileWritable(StringRef Path) {
+bool elf::isFileWritable(StringRef Path, StringRef FileDescription) {
   if (auto EC = FileOutputBuffer::create(Path, 1).getError()) {
----------------
We generally use short variable names unlike JavaIshLongVariableName, so let's name this `Desc`.


https://reviews.llvm.org/D31603